netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: Dan Kruchinin <dkruchinin@acm.org>,
	netdev@vger.kernel.org, Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [RFC][PATCH] QoS TBF and latency configuration misbehavior
Date: Wed, 1 Sep 2010 06:36:03 +0000	[thread overview]
Message-ID: <20100901063602.GA6285@ff.dom.local> (raw)
In-Reply-To: <20100831223402.GA7101@ms2.inr.ac.ru>

On Wed, Sep 01, 2010 at 02:34:02AM +0400, Alexey Kuznetsov wrote:
> Hello!
Hi!

> To Jarek: about the scripts. I do not think something will be broken
> by fixing this error. Eventually, if someone used "latency", he meant
> something about real latency. And even if the value was generated
> using the same wrong logic as tc did, using correct formula would just
> increase limit setting.

As I wrote earlier, I'm more worried about configs based on experience,
not logic. Dan's tests show there could be a difference, and I'm not
sure users cared about the logic, since it wasn't questioned until now.
Btw, there could be considered adding a new, alternative parameter, for
this, like rlatency etc. if it's so crucial. And, of course, it's only
my little "IMHO", I don't insist on anything.

Thanks,
Jarek P.

  reply	other threads:[~2010-09-01  6:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 13:56 [RFC][PATCH] QoS TBF and latency configuration misbehavior Dan Kruchinin
2010-08-31 17:01 ` Dan Kruchinin
2010-08-31 19:57   ` Jarek Poplawski
2010-08-31 21:00     ` Dan Kruchinin
2010-08-31 21:47       ` Jarek Poplawski
2010-08-31 21:48       ` Alexey Kuznetsov
2010-08-31 22:34         ` Alexey Kuznetsov
2010-09-01  6:36           ` Jarek Poplawski [this message]
2010-09-01  8:40             ` Alexey Kuznetsov
2010-09-01 11:29           ` Dan Kruchinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100901063602.GA6285@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=dkruchinin@acm.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).