From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] drivers/net : avoid some skb->ip_summed initializations
Date: Thu, 02 Sep 2010 09:41:35 -0700 (PDT) [thread overview]
Message-ID: <20100902.094135.112603353.davem@davemloft.net> (raw)
In-Reply-To: <1283444746.2454.1132.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 02 Sep 2010 18:25:46 +0200
> fresh skbs have ip_summed set to CHECKSUM_NONE (0)
>
> We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
>
> Introduce skb_CHECKSUM_NONE_assert() helper so that we keep this
> assertion documented in driver sources.
>
> Change most occurrences of :
>
> skb->ip_summed = CHECKSUM_NONE;
>
> by :
>
> skb_CHECKSUM_NONE_assert(skb);
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Please, no capital letters in C function names.
I'll apply this with that fixed up.
Thanks.
next prev parent reply other threads:[~2010-09-02 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 16:25 [PATCH net-next-2.6] drivers/net : avoid some skb->ip_summed initializations Eric Dumazet
2010-09-02 16:41 ` David Miller [this message]
2010-09-02 19:13 ` Eric Dumazet
2010-09-02 19:38 ` David Miller
2010-09-02 19:55 ` Eric Dumazet
2010-09-02 20:08 ` David Miller
2010-09-03 2:07 ` David Miller
2010-09-03 5:17 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902.094135.112603353.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).