From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: rmody@brocade.com, netdev@vger.kernel.org, amathur@brocade.com,
ddutt@brocade.com, huangj@brocade.com
Subject: Re: [PATCH net-next-2.6] bna: fix stats handling
Date: Thu, 02 Sep 2010 12:45:14 -0700 (PDT) [thread overview]
Message-ID: <20100902.124514.245410670.davem@davemloft.net> (raw)
In-Reply-To: <1283455623.3699.56.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 02 Sep 2010 21:27:03 +0200
> [PATCH net-next-2.6] bna: fix stats handling
>
> get_stats() method incorrectly clears a global array before folding
> various stats. This can break SNMP applications.
>
> Switch to 64 bit flavor to work on a user supplied buffer, and provide
> 64bit counters even on 32bit arches.
>
> Fix a bug in bnad_netdev_hwstats_fill(), for rx_fifo_errors, missing a
> folding (only the last counter was taken into account)
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Rasesh Mody <rmody@brocade.com>
Applied.
next prev parent reply other threads:[~2010-09-02 19:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 21:23 [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver Rasesh Mody
2010-08-24 3:35 ` David Miller
2010-08-24 5:31 ` [PATCH net-next-2.6] bna: fix stats handling Eric Dumazet
2010-08-24 17:52 ` Debashis Dutt
2010-08-24 18:49 ` Rasesh Mody
2010-08-24 19:06 ` Eric Dumazet
2010-08-24 19:36 ` David Miller
2010-08-24 20:48 ` Rasesh Mody
2010-08-30 17:38 ` Rasesh Mody
2010-09-02 19:27 ` Eric Dumazet
2010-09-02 19:45 ` David Miller [this message]
2010-08-24 6:15 ` [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver Debashis Dutt
2010-08-24 6:27 ` Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902.124514.245410670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amathur@brocade.com \
--cc=ddutt@brocade.com \
--cc=eric.dumazet@gmail.com \
--cc=huangj@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).