From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: Fix lockdep warning on est_tree_lock in gen_estimator
Date: Thu, 2 Sep 2010 23:22:45 +0200 [thread overview]
Message-ID: <20100902212245.GA5210@del.dom.local> (raw)
In-Reply-To: <1283460813.3699.243.camel@edumazet-laptop>
On Thu, Sep 02, 2010 at 10:53:33PM +0200, Eric Dumazet wrote:
> Le jeudi 02 septembre 2010 ?? 22:12 +0200, Jarek Poplawski a écrit :
> > @@ -270,7 +270,7 @@ void gen_kill_estimator(struct gnet_stats_basic_packed *bstats,
> > {
> > struct gen_estimator *e;
> >
> > - spin_lock(&est_tree_lock);
> > + spin_lock_bh(&est_tree_lock);
> > while ((e = gen_find_node(bstats, rate_est))) {
> > rb_erase(&e->node, &est_root);
> >
>
> If you lock bh for est_tree_lock(), we dont need _bh for est_lock here
Right. But since the patch was merged and it's not crucial, I guess
you could send a separate patch?
Thanks,
Jarek P.
prev parent reply other threads:[~2010-09-02 21:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 20:12 [PATCH] pkt_sched: Fix lockdep warning on est_tree_lock in gen_estimator Jarek Poplawski
2010-09-02 20:22 ` David Miller
2010-09-02 20:32 ` Eric Dumazet
2010-09-02 20:55 ` Jarek Poplawski
2010-09-03 5:26 ` Eric Dumazet
2010-09-02 20:53 ` Eric Dumazet
2010-09-02 20:59 ` David Miller
2010-09-02 21:22 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902212245.GA5210@del.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).