* [PATCH net-next-2.6] net: remove two kmemcheck annotations
@ 2010-09-03 16:27 Eric Dumazet
2010-09-03 16:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2010-09-03 16:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev
__alloc_skb() uses a memset() to clear all the beginning of skb,
including bitfields contained in 'flags1' & 'flags2'.
We dont need any more to use kmemcheck_annotate_bitfield() on these
fields. However, we still need it for the clone part, which is not
cleared.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/core/skbuff.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 231dff0..c030cf8 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -202,8 +202,6 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
skb->data = data;
skb_reset_tail_pointer(skb);
skb->end = skb->tail + size;
- kmemcheck_annotate_bitfield(skb, flags1);
- kmemcheck_annotate_bitfield(skb, flags2);
#ifdef NET_SKBUFF_DATA_USES_OFFSET
skb->mac_header = ~0U;
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next-2.6] net: remove two kmemcheck annotations
2010-09-03 16:27 [PATCH net-next-2.6] net: remove two kmemcheck annotations Eric Dumazet
@ 2010-09-03 16:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-03 16:45 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 03 Sep 2010 18:27:08 +0200
> __alloc_skb() uses a memset() to clear all the beginning of skb,
> including bitfields contained in 'flags1' & 'flags2'.
>
> We dont need any more to use kmemcheck_annotate_bitfield() on these
> fields. However, we still need it for the clone part, which is not
> cleared.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-03 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 16:27 [PATCH net-next-2.6] net: remove two kmemcheck annotations Eric Dumazet
2010-09-03 16:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).