From: David Miller <davem@davemloft.net>
To: david-b@pacbell.net
Cc: netdev@vger.kernel.org, linux@rainbow-software.org
Subject: Re: PATCH: usbnet: doc updates
Date: Sun, 05 Sep 2010 17:12:27 -0700 (PDT) [thread overview]
Message-ID: <20100905.171227.193704987.davem@davemloft.net> (raw)
In-Reply-To: <298165.21593.qm@web180307.mail.gq1.yahoo.com>
From: David Brownell <david-b@pacbell.net>
Date: Sun, 5 Sep 2010 17:06:10 -0700 (PDT)
> Apologies in advance for sending this as an
> attachment, but I think it's less likely to get
> angled (except quoted-printable?) this way.
Well, patchwork didn't grok it at all, and this means your patch is a
lot more work for me.
Actually looking at the patch, the comment formatting is not all
that pretty:
+ * Note that the design center for usbnet has one IEEE packet per URB, and
+maps network TX and RX queues directly to the USB hardware TX/RX queues,
Please start every line of the comment with the
proper leading " * " rather than going straight to
the text.
+ /* fixup rx packet ( by stripping framing from URB/SKB.
+ *
+ - If SKB batches one or more packets, pass all but one of them
+ up the stack (clone SKB and fixup each clone before netif_rx)).
Please also do the same here.
next prev parent reply other threads:[~2010-09-06 0:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 0:06 PATCH: usbnet: doc updates David Brownell
2010-09-06 0:12 ` David Miller [this message]
2010-09-06 4:38 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2010-09-06 4:48 David Brownell
2010-09-06 4:57 ` David Miller
2010-09-06 18:28 ` David Brownell
2010-09-06 19:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100905.171227.193704987.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).