From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] stmmac: fix sleep inside atomic
Date: Mon, 06 Sep 2010 13:11:07 -0700 (PDT) [thread overview]
Message-ID: <20100906.131107.183045782.davem@davemloft.net> (raw)
In-Reply-To: <1283742379-9610-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Mon, 6 Sep 2010 05:06:19 +0200
> We cannot use spinlock when kmalloc is invoked with
> GFP_KERNEL flag because it can sleep.
> So this patch reviews the usage of spinlock within the
> stmmac_resume function avoing this bug.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied, but you are extremely guilty of the sin of omission
here.
Why in the world did you not at least CC: Jiri, the person
who reported this problem? You should do that at a minimum
when someone reports a problem with code you are fixing.
And in this case he definitely deserves a
Reported-by:
tag in the commit message as well.
Please don't fail to acknowledge a reporter's efforts like
this ever again.
next prev parent reply other threads:[~2010-09-06 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 3:06 [PATCH] stmmac: fix sleep inside atomic Giuseppe CAVALLARO
2010-09-06 20:11 ` David Miller [this message]
2010-09-07 5:55 ` Peppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906.131107.183045782.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).