* PATCH: b44 Handle RX FIFO overflow better (simplified)
@ 2010-09-05 0:17 Mark Lord
2010-09-07 1:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mark Lord @ 2010-09-05 0:17 UTC (permalink / raw)
To: linux-kernel-owner@vger.kernel.org; +Cc: netdev, David S. Miller, James
This patch is a simplified version of the original patch from James Courtier-Dutton.
>From: James Courtier-Dutton
>Subject: [PATCH] Fix b44 RX FIFO overflow recovery.
>Date: Wednesday, June 30, 2010 - 1:11 pm
>
>This patch improves the recovery after a RX FIFO overflow on the b44
>Ethernet NIC.
>Before it would do a complete chip reset, resulting is loss of link
>for a few seconds.
>This patch improves this to do recovery in about 20ms without loss of link.
>
>Signed off by: James@superbug.co.uk
Signed-off-by: Mark Lord <mlord@pobox.com>
--- a/drivers/net/b44.c 2010-09-04 20:02:27.539248270 -0400
+++ b/drivers/net/b44.c 2010-09-04 20:07:03.749248234 -0400
@@ -851,6 +851,15 @@
b44_tx(bp);
/* spin_unlock(&bp->tx_lock); */
}
+ if (bp->istat & ISTAT_RFO) { /* fast recovery, in ~20msec */
+ bp->istat &= ~ISTAT_RFO;
+ b44_disable_ints(bp);
+ ssb_device_enable(bp->sdev, 0); /* resets ISTAT_RFO */
+ b44_init_rings(bp);
+ b44_init_hw(bp, B44_FULL_RESET_SKIP_PHY);
+ netif_wake_queue(bp->dev);
+ }
+
spin_unlock_irqrestore(&bp->lock, flags);
work_done = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: PATCH: b44 Handle RX FIFO overflow better (simplified)
2010-09-05 0:17 PATCH: b44 Handle RX FIFO overflow better (simplified) Mark Lord
@ 2010-09-07 1:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-07 1:35 UTC (permalink / raw)
To: kernel; +Cc: linux-kernel-owner, netdev, James
From: Mark Lord <kernel@teksavvy.com>
Date: Sat, 04 Sep 2010 20:17:59 -0400
> This patch is a simplified version of the original patch from James Courtier-Dutton.
>
>>From: James Courtier-Dutton
>>Subject: [PATCH] Fix b44 RX FIFO overflow recovery.
>>Date: Wednesday, June 30, 2010 - 1:11 pm
>>
>>This patch improves the recovery after a RX FIFO overflow on the b44
>>Ethernet NIC.
>>Before it would do a complete chip reset, resulting is loss of link
>>for a few seconds.
>>This patch improves this to do recovery in about 20ms without loss of link.
>>
>>Signed off by: James@superbug.co.uk
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
Applied, thanks Mark.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-07 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-05 0:17 PATCH: b44 Handle RX FIFO overflow better (simplified) Mark Lord
2010-09-07 1:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).