Re: [PATCH net-next 00/10] bnx2x: Dual-media enhancement

Re: [PATCH net-next 00/10] bnx2x: Dual-media enhancement

[David Miller]

From: "Yaniv Rosner" <yaniv.rosner@broadcom.com>
Date: Wed, 8 Sep 2010 00:40:45 +0300

> Hi Dave,
> The following patch series describe gradually code changes to support
> dual-media boards. Among other, this change required to split common PHY
> functions into PHY specific functions, so we took advantage of this
> opportunity and moved to a method which is very similar to the phy lib,
> i.e. PHY oriented. We hope that this way will enable us to integrate
> with the phy lib easily later on.
> 
> Please consider applying it to net-next.

Applied, but you're definitely not validating your patches using
git's automatic whitespace validation checks.

Applying: bnx2x: Unify PHY attributes
/home/davem/src/GIT/net-next-2.6/.git/rebase-apply/patch:4993: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

And also:

Applying: bnx2x: Move common function into aggregated function
/home/davem/src/GIT/net-next-2.6/.git/rebase-apply/patch:91: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

I've fixed them up this time, but you will need to take care of these
things yourself next time or else I'll push the patches back to you.

RE: [PATCH net-next 00/10] bnx2x: Dual-media enhancement

[Yaniv Rosner]

Dave,
Thank you so much ! Will do.
Yaniv

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Tuesday, September 07, 2010 11:13 PM
To: Yaniv Rosner
Cc: netdev@vger.kernel.org; Eilon Greenstein
Subject: Re: [PATCH net-next 00/10] bnx2x: Dual-media enhancement

From: "Yaniv Rosner" <yaniv.rosner@broadcom.com>
Date: Wed, 8 Sep 2010 00:40:45 +0300

> Hi Dave,
> The following patch series describe gradually code changes to support
> dual-media boards. Among other, this change required to split common PHY
> functions into PHY specific functions, so we took advantage of this
> opportunity and moved to a method which is very similar to the phy lib,
> i.e. PHY oriented. We hope that this way will enable us to integrate
> with the phy lib easily later on.
> 
> Please consider applying it to net-next.

Applied, but you're definitely not validating your patches using
git's automatic whitespace validation checks.

Applying: bnx2x: Unify PHY attributes
/home/davem/src/GIT/net-next-2.6/.git/rebase-apply/patch:4993: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

And also:

Applying: bnx2x: Move common function into aggregated function
/home/davem/src/GIT/net-next-2.6/.git/rebase-apply/patch:91: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

I've fixed them up this time, but you will need to take care of these
things yourself next time or else I'll push the patches back to you.

[PATCH net-next 00/10] bnx2x: Dual-media enhancement

[Yaniv Rosner]

Hi Dave,
The following patch series describe gradually code changes to support
dual-media boards. Among other, this change required to split common PHY
functions into PHY specific functions, so we took advantage of this
opportunity and moved to a method which is very similar to the phy lib,
i.e. PHY oriented. We hope that this way will enable us to integrate
with the phy lib easily later on.

Please consider applying it to net-next.

Thanks,
Yaniv