From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] r8169: add gro support
Date: Tue, 07 Sep 2010 13:47:45 -0700 (PDT) [thread overview]
Message-ID: <20100907.134745.115939406.davem@davemloft.net> (raw)
In-Reply-To: <20100907202445.GA11841@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Tue, 7 Sep 2010 22:24:45 +0200
> Eric Dumazet <eric.dumazet@gmail.com> :
>> - Use napi_gro_receive() and vlan_gro_receive()
>> - Enable GRO by default
>>
>> Tested on a RTL8111/8168 adapter
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>> CC: Francois Romieu <romieu@fr.zoreil.com>
> [...]
>> @@ -1076,7 +1076,12 @@ static int rtl8169_rx_vlan_skb(struct rtl8169_private *tp, struct RxDesc *desc,
>> int ret;
>>
>> if (vlgrp && (opts2 & RxVlanTag)) {
>> - __vlan_hwaccel_rx(skb, vlgrp, swab16(opts2 & 0xffff), polling);
>> + u16 vtag = swab16(opts2 & 0xffff);
>> +
>> + if (polling)
>
> if (likely(polling))
>
> Otherwise Acked-by: Francois Romieu <romieu@fr.zoreil.com>
I've made this change and applied the patch, thanks guys!
prev parent reply other threads:[~2010-09-07 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 4:46 [PATCH net-next-2.6] r8169: add gro support Eric Dumazet
2010-09-07 20:24 ` Francois Romieu
2010-09-07 20:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907.134745.115939406.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).