From: Nick Bowler <nbowler@elliptictech.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
trivial@kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline
Date: Tue, 7 Sep 2010 11:37:21 -0400 [thread overview]
Message-ID: <20100907153721.GA6419@elliptictech.com> (raw)
In-Reply-To: <1283835677.23280.108.camel@Joe-Laptop>
On 2010-09-06 22:01 -0700, Joe Perches wrote:
> diff --git a/include/net/raw.h b/include/net/raw.h
> index 43c5750..c621200 100644
> --- a/include/net/raw.h
> +++ b/include/net/raw.h
> @@ -45,7 +45,10 @@ struct raw_iter_state {
> struct raw_hashinfo *h;
> };
>
> -#define raw_seq_private(seq) ((struct raw_iter_state *)(seq)->private)
> +inline struct raw_iter_state *raw_seq_private(struct seq_file *seq)
This needs to be declared static.
> +{
> + return seq->private;
> +}
> void *raw_seq_start(struct seq_file *seq, loff_t *pos);
> void *raw_seq_next(struct seq_file *seq, void *v, loff_t *pos);
> void raw_seq_stop(struct seq_file *seq, void *v);
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2010-09-07 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 1:52 [PATCH 00/13] trivial: Remove unnecessary casts of private_data Joe Perches
2010-09-05 1:52 ` [PATCH 03/13] drivers/net/wireless/iwlwifi: " Joe Perches
2010-09-05 1:52 ` [PATCH 11/13] net/ipv4: " Joe Perches
2010-09-07 1:30 ` David Miller
2010-09-07 1:47 ` David Miller
2010-09-07 5:01 ` [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline Joe Perches
2010-09-07 15:37 ` Nick Bowler [this message]
2010-09-07 15:55 ` [PATCH V2 " Joe Perches
2010-09-08 20:42 ` David Miller
2010-09-05 1:52 ` [PATCH 12/13] net/sunrpc/rpc_pipe.c: Remove unnecessary casts of private_data Joe Perches
[not found] ` <dda96f0e94bd038179ae11dab4d73a7ab704276b.1283650107.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-09-23 11:40 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907153721.GA6419@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=trivial@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).