netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: NFS writes broken in net-next-2.6
Date: Wed, 08 Sep 2010 13:05:50 -0700 (PDT)	[thread overview]
Message-ID: <20100908.130550.115952209.davem@davemloft.net> (raw)
In-Reply-To: <1283976068.2237.8.camel-xQnnTUlwzDrdvaEqJLTMTA9jg9n5Vt1AMm0uRHvK7Nw@public.gmane.org>

From: Ben Hutchings <bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
Date: Wed, 08 Sep 2010 21:01:08 +0100

> In net-next-2.6, close() of a file after writing tends to return 1.
> This causes e.g. gcc to abort.
> 
> This appears to have been fixed in 2.6.36-rc2:
> 
> commit 0702099bd86c33c2dcdbd3963433a61f3f503901
> Author: J. R. Okajima <hooanon05-/E1597aS9LR3+QwDJ9on6Q@public.gmane.org>
> Date:   Wed Aug 11 13:10:16 2010 -0400
> 
>     NFS: fix the return value of nfs_file_fsync()
> 
> Please consider merging this fix in some way.

Ben, and please I've told you this before, if you need a specific
upstream fix do your testing on a branch that pulls in Linus's tree
or, alternatively, apply the fix you need by hand using "git stash" or
similar.

All of this is in your own hands.  You do not need me to merge in
every single upstream fix you might need.

I have this issue myself when testing both the sparc tree and the
various net trees all the time.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-09-08 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 20:01 NFS writes broken in net-next-2.6 Ben Hutchings
     [not found] ` <1283976068.2237.8.camel-xQnnTUlwzDrdvaEqJLTMTA9jg9n5Vt1AMm0uRHvK7Nw@public.gmane.org>
2010-09-08 20:05   ` David Miller [this message]
     [not found]     ` <20100908.130550.115952209.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-09-08 20:14       ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100908.130550.115952209.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).