Re: [PATCH net-next-2.6] ethtool: Complete kernel-doc comments for RX flow filter and hash control

[David Miller <davem@davemloft.net>]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 07 Sep 2010 15:46:20 +0100

> On Tue, 2010-09-07 at 15:41 +0100, Ben Hutchings wrote:
>> There are now several interfaces within the ethtool API for getting
>> and setting RX flow filtering and hashing behaviour, most of which are
>> poorly documented.  This adds kernel-doc comments for all these
>> interfaces, based on the existing incomplete comments and on the
>> initial implementations.
>> 
>> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>> ---
>> Santwona, Peter,
>> 
>> Please point out any errors and any information that should be added to
>> the comments to explain the significant differences between the RXNFC
>> and RXNTUPLE interfaces.
> [...]
>> +/**
>> + * struct ethtool_rx_ntuple - command to get or set RX flow filter
>> + * @cmd: Specific command number - %ETHTOOL_GRXNTUPLE or %ETHTOOL_SRXNTUPLE
> 
> Of course this is wrong - ETHTOOL_GRXNTUPLE uses struct ethtool_gstrings
> instead.

Ben, please submit a fixed up version of the patch.

Thanks.