From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
jesse.brandeburg@intel.com
Subject: Re: [net-next-2.6 PATCH] e1000: fix Tx hangs by disabling 64-bit DMA
Date: Wed, 08 Sep 2010 14:22:07 -0700 (PDT) [thread overview]
Message-ID: <20100908.142207.258102173.davem@davemloft.net> (raw)
In-Reply-To: <20100908065835.315.15437.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 08 Sep 2010 00:01:12 -0700
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Several users report issues with 32-bit adapters when plugged
> into PCI slots in machines with >= 4GB ram. In particular AMD
> systems with HyperTransport to PCI bridges seem to trigger the
> issue, but it isn't limited to only them.
>
> This issue is not easily reproducible here, yet still continues
> to occur in the field. For e1000 on PCI devices, just disable DMA
> addresses over the 4GB boundary when in PCI (not PCI-X) mode, to
> prevent the issue from continuing to pop up. The performance
> impact for this is negligible.
>
> The code was refactored to move the init of the hw struct to its
> own function. This allows the init to be called very early in
> probe, which then allows using hw-> members for this fix.
>
> A slight refactor to the DMA mask code was done for minor
> correctness based on the instructions in DMA-API-HOWTO.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks guys.
prev parent reply other threads:[~2010-09-08 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 7:01 [net-next-2.6 PATCH] e1000: fix Tx hangs by disabling 64-bit DMA Jeff Kirsher
2010-09-08 21:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908.142207.258102173.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).