From: David Miller <davem@davemloft.net>
To: jon.mason@exar.com
Cc: error27@gmail.com, Ramkrishna.Vepa@exar.com,
Sivakumar.Subramani@exar.com, Sreenivasa.Honnur@exar.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] vxge: potential NULL dereference
Date: Fri, 10 Sep 2010 14:40:44 -0700 (PDT) [thread overview]
Message-ID: <20100910.144044.90810785.davem@davemloft.net> (raw)
In-Reply-To: <20100910213214.GH22321@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Fri, 10 Sep 2010 17:32:15 -0400
> It is possible to the vpath to be NULL in this array if it is not
> populated in __vxge_hw_vp_initialize due to the vpath being masked off
> my the adapter. vxge_hw_device_begin_irq calls
> __vxge_hw_vpath_alarm_process on all possible vpaths regardless of
> their allocation. This is the case we need to worry about.
>
> It is not an issue because in the first instance of the vpath being
> NULL, its sets the alarm_event to be VXGE_HW_EVENT_UNKNOWN. The first
> check in the out2 error path checks for VXGE_HW_EVENT_UNKNOWN and
> returns. So its not possible to hit this...though it is ugly code. I
> welcome a reworking of the code to something mroe elegant. :)
Aha, I see, thanks for explaining this.
prev parent reply other threads:[~2010-09-10 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 11:54 [patch] vxge: potential NULL dereference Dan Carpenter
2010-09-10 20:32 ` David Miller
2010-09-10 21:12 ` Dan Carpenter
2010-09-10 21:32 ` Jon Mason
2010-09-10 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910.144044.90810785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ramkrishna.Vepa@exar.com \
--cc=Sivakumar.Subramani@exar.com \
--cc=Sreenivasa.Honnur@exar.com \
--cc=error27@gmail.com \
--cc=jon.mason@exar.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).