From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] vxge: potential NULL dereference Date: Fri, 10 Sep 2010 13:54:23 +0200 Message-ID: <20100910115423.GC5959@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sivakumar Subramani , Sreenivasa Honnur , Jon Mason , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Ramkrishna Vepa Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:56012 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753261Ab0IJLyi (ORCPT ); Fri, 10 Sep 2010 07:54:38 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: At the start of the function we test whether the "vpath" is NULL but we need another test here as well. Signed-off-by: Dan Carpenter --- This is a static checker bug, I'm not sure if we ever pass a NULL pointer for "vpath". diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-traffic.c index cedf08f..1790748 100644 --- a/drivers/net/vxge/vxge-traffic.c +++ b/drivers/net/vxge/vxge-traffic.c @@ -2157,7 +2157,8 @@ out2: (alarm_event == VXGE_HW_EVENT_UNKNOWN)) return VXGE_HW_OK; - __vxge_hw_device_handle_error(hldev, vpath->vp_id, alarm_event); + if (vpath) + __vxge_hw_device_handle_error(hldev, vpath->vp_id, alarm_event); if (alarm_event == VXGE_HW_EVENT_SERR) return VXGE_HW_ERR_CRITICAL;