From: David Miller <davem@davemloft.net>
To: jirislaby@gmail.com
Cc: ddutt@brocade.com, rmody@brocade.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: bna: potential null dereference
Date: Sun, 12 Sep 2010 12:02:30 -0700 (PDT) [thread overview]
Message-ID: <20100912.120230.71108625.davem@davemloft.net> (raw)
In-Reply-To: <4C8242CA.3020906@gmail.com>
From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 04 Sep 2010 14:59:54 +0200
> stanse found a potential null dereference:
> bnad_cb_tx_cleanup
> -> struct bnad_unmap_q *unmap_q = tcb->unmap_q;
> -> -- tcb cannot be null now --
> -> if (!tcb || (!tcb->unmap_q))
>
> The thing is I have no idea whether the second parameter of cleanup may
> be null (move assignment after the check) or not (remove the check)
>
> Could you fix that?
Since the Brocade folks can't be bothered to fix this for more than
a week I'll take care of this, thanks Jiri.
next prev parent reply other threads:[~2010-09-12 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 12:59 bna: potential null dereference Jiri Slaby
2010-09-12 19:02 ` David Miller [this message]
[not found] ` <AANLkTi=cZyLYJac8b8MsyAA4HitCvpD3NaH7nifzHDLw@mail.gmail.com>
2010-09-12 22:38 ` David Miller
2010-09-12 22:41 ` Debashis Dutt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100912.120230.71108625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ddutt@brocade.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).