From: "Michael S. Tsirkin" <mst@redhat.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out
Date: Sun, 12 Sep 2010 14:13:49 +0200 [thread overview]
Message-ID: <20100912121349.GD22982@redhat.com> (raw)
In-Reply-To: <1284175403-3228-1-git-send-email-xiaosuo@gmail.com>
On Sat, Sep 11, 2010 at 11:23:23AM +0800, Changli Gao wrote:
> @@ -799,7 +806,9 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
>
> memcpy((struct skb_shared_info *)(data + size),
> skb_shinfo(skb),
> - offsetof(struct skb_shared_info, frags[skb_shinfo(skb)->nr_frags]));
> + offsetof(struct skb_shared_info,
> + frags[skb_shinfo(skb)->nr_frags]));
> + skb_shinfo(skb)->destructor = NULL;
>
> /* Check if we can avoid taking references on fragments if we own
> * the last reference on skb->head. (see skb_release_data())
So it looks like pskb_expand_head will prevent the shinfo desctructor
from being called, ever? If so, won't this break af_packet?
--
MST
next prev parent reply other threads:[~2010-09-12 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 3:23 [PATCH v2] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out Changli Gao
2010-09-12 12:13 ` Michael S. Tsirkin [this message]
2010-09-15 3:20 ` David Miller
2010-09-15 5:23 ` Michael S. Tsirkin
2010-09-22 9:35 ` Changli Gao
2010-09-22 10:59 ` Michael S. Tsirkin
2010-09-22 9:24 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100912121349.GD22982@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).