* Re: [33-stable regression ssb/broadcom] [not found] <4C8E6192.2010003@mandriva.org> @ 2010-09-13 19:23 ` David Miller 2010-09-13 19:36 ` John W. Linville 0 siblings, 1 reply; 7+ messages in thread From: David Miller @ 2010-09-13 19:23 UTC (permalink / raw) To: tmb; +Cc: stable, gregkh, Larry.Finger, linux-kernel, netdev From: Thomas Backlund <tmb@mandriva.org> Date: Mon, 13 Sep 2010 20:38:26 +0300 > In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for > several users... > > Issue is tracked at: > https://qa.mandriva.com/show_bug.cgi?id=60968 > > Reverting the commit restores a working lan. > > The offending commit is: Please always CC: netdev on networking reports, otherwise you are very unlikely to get any experts looking into your issue. > --- cut --- > From 6fb037c2ed8378c7ab0c1e00536ba6b2a866503e Mon Sep 17 00:00:00 2001 > From: Christoph Fritz <chf.fritz@googlemail.com> > Date: Sun, 11 Jul 2010 18:26:15 -0500 > Subject: [PATCH] ssb: Handle Netbook devices where the SPROM address > is changed > > For some Netbook computers with Broadcom BCM4312 wireless interfaces, > the SPROM has been moved to a new location. When the ssb driver tries > to > read the old location, the systems hangs when trying to read a > non-existent location. Such freezes are particularly bad as they do > not > log the failure. > > This patch is modified from commit > da1fdb02d9200ff28b6f3a380d21930335fe5429 with some pieces from other > mainline changes so that it can be applied to stable 2.6.34.Y. > --- cut --- > > -- > Thomas > -- > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [33-stable regression ssb/broadcom] 2010-09-13 19:23 ` [33-stable regression ssb/broadcom] David Miller @ 2010-09-13 19:36 ` John W. Linville 2010-09-13 20:34 ` Thomas Backlund 0 siblings, 1 reply; 7+ messages in thread From: John W. Linville @ 2010-09-13 19:36 UTC (permalink / raw) To: David Miller; +Cc: tmb, stable, gregkh, Larry.Finger, linux-kernel, netdev On Mon, Sep 13, 2010 at 12:23:29PM -0700, David Miller wrote: > From: Thomas Backlund <tmb@mandriva.org> > Date: Mon, 13 Sep 2010 20:38:26 +0300 > > > In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for > > several users... > > > > Issue is tracked at: > > https://qa.mandriva.com/show_bug.cgi?id=60968 > > > > Reverting the commit restores a working lan. > > > > The offending commit is: > > Please always CC: netdev on networking reports, otherwise you are > very unlikely to get any experts looking into your issue. IIRC, there was a bad patch that got sent for the 2.6.33.y series. I thought it had been reverted or fixed already? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [33-stable regression ssb/broadcom] 2010-09-13 19:36 ` John W. Linville @ 2010-09-13 20:34 ` Thomas Backlund 2010-09-13 20:41 ` Thomas Backlund 0 siblings, 1 reply; 7+ messages in thread From: Thomas Backlund @ 2010-09-13 20:34 UTC (permalink / raw) To: John W. Linville Cc: David Miller, stable@kernel.org, gregkh@suse.de, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org John W. Linville skrev 13.9.2010 22:36: > On Mon, Sep 13, 2010 at 12:23:29PM -0700, David Miller wrote: >> From: Thomas Backlund<tmb@mandriva.org> >> Date: Mon, 13 Sep 2010 20:38:26 +0300 >> >>> In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for >>> several users... >>> >>> Issue is tracked at: >>> https://qa.mandriva.com/show_bug.cgi?id=60968 >>> >>> Reverting the commit restores a working lan. >>> >>> The offending commit is: >> >> Please always CC: netdev on networking reports, otherwise you are >> very unlikely to get any experts looking into your issue. > > IIRC, there was a bad patch that got sent for the 2.6.33.y series. > I thought it had been reverted or fixed already? > Nope. It got added in 2.6.33.7 http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.33.y.git;a=commit;h=6fb037c2ed8378c7ab0c1e00536ba6b2a866503e -- Thomas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [33-stable regression ssb/broadcom] 2010-09-13 20:34 ` Thomas Backlund @ 2010-09-13 20:41 ` Thomas Backlund 2010-09-13 21:01 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Thomas Backlund @ 2010-09-13 20:41 UTC (permalink / raw) To: stable@kernel.org Cc: John W. Linville, David Miller, gregkh@suse.de, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Thomas Backlund skrev 13.9.2010 23:34: > John W. Linville skrev 13.9.2010 22:36: >> On Mon, Sep 13, 2010 at 12:23:29PM -0700, David Miller wrote: >>> From: Thomas Backlund<tmb@mandriva.org> >>> Date: Mon, 13 Sep 2010 20:38:26 +0300 >>> >>>> In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for >>>> several users... >>>> >>>> Issue is tracked at: >>>> https://qa.mandriva.com/show_bug.cgi?id=60968 >>>> >>>> Reverting the commit restores a working lan. >>>> >>>> The offending commit is: >>> >>> Please always CC: netdev on networking reports, otherwise you are >>> very unlikely to get any experts looking into your issue. >> >> IIRC, there was a bad patch that got sent for the 2.6.33.y series. >> I thought it had been reverted or fixed already? >> > > Nope. > > It got added in 2.6.33.7 > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.33.y.git;a=commit;h=6fb037c2ed8378c7ab0c1e00536ba6b2a866503e > After checking some more... I see the revert of the broken patch was done in 2.6.34.3 and a set of ssb patches replacing it... but it didn't happend for 2.6.33.y -- Thomas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [33-stable regression ssb/broadcom] 2010-09-13 20:41 ` Thomas Backlund @ 2010-09-13 21:01 ` Greg KH 2010-09-15 9:54 ` Thomas Backlund 0 siblings, 1 reply; 7+ messages in thread From: Greg KH @ 2010-09-13 21:01 UTC (permalink / raw) To: Thomas Backlund Cc: stable@kernel.org, John W. Linville, David Miller, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org On Mon, Sep 13, 2010 at 11:41:23PM +0300, Thomas Backlund wrote: > Thomas Backlund skrev 13.9.2010 23:34: > >John W. Linville skrev 13.9.2010 22:36: > >>On Mon, Sep 13, 2010 at 12:23:29PM -0700, David Miller wrote: > >>>From: Thomas Backlund<tmb@mandriva.org> > >>>Date: Mon, 13 Sep 2010 20:38:26 +0300 > >>> > >>>>In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for > >>>>several users... > >>>> > >>>>Issue is tracked at: > >>>>https://qa.mandriva.com/show_bug.cgi?id=60968 > >>>> > >>>>Reverting the commit restores a working lan. > >>>> > >>>>The offending commit is: > >>> > >>>Please always CC: netdev on networking reports, otherwise you are > >>>very unlikely to get any experts looking into your issue. > >> > >>IIRC, there was a bad patch that got sent for the 2.6.33.y series. > >>I thought it had been reverted or fixed already? > >> > > > >Nope. > > > >It got added in 2.6.33.7 > >http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.33.y.git;a=commit;h=6fb037c2ed8378c7ab0c1e00536ba6b2a866503e > > > > After checking some more... > > I see the revert of the broken patch was done in 2.6.34.3 and a set > of ssb patches replacing it... > > but it didn't happend for 2.6.33.y Yeah, I think I "dropped" support for .33 by then and I really didn't care anymore. Note, I have gotten a few rumblings that I should bring .33 back to life for some loving due to a few distros relying on it, but I need to find the time in my schedule to do so... thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [33-stable regression ssb/broadcom] 2010-09-13 21:01 ` Greg KH @ 2010-09-15 9:54 ` Thomas Backlund 2010-09-15 10:02 ` Krzysztof Olędzki 0 siblings, 1 reply; 7+ messages in thread From: Thomas Backlund @ 2010-09-15 9:54 UTC (permalink / raw) To: Greg KH Cc: stable@kernel.org, John W. Linville, David Miller, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Greg KH skrev 14.9.2010 00:01: > On Mon, Sep 13, 2010 at 11:41:23PM +0300, Thomas Backlund wrote: >> Thomas Backlund skrev 13.9.2010 23:34: >>> John W. Linville skrev 13.9.2010 22:36: >>>> On Mon, Sep 13, 2010 at 12:23:29PM -0700, David Miller wrote: >>>>> From: Thomas Backlund<tmb@mandriva.org> >>>>> Date: Mon, 13 Sep 2010 20:38:26 +0300 >>>>> >>>>>> In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for >>>>>> several users... >>>>>> >>>>>> Issue is tracked at: >>>>>> https://qa.mandriva.com/show_bug.cgi?id=60968 >>>>>> >>>>>> Reverting the commit restores a working lan. >>>>>> >>>>>> The offending commit is: >>>>> >>>>> Please always CC: netdev on networking reports, otherwise you are >>>>> very unlikely to get any experts looking into your issue. >>>> >>>> IIRC, there was a bad patch that got sent for the 2.6.33.y series. >>>> I thought it had been reverted or fixed already? >>>> >>> >>> Nope. >>> >>> It got added in 2.6.33.7 >>> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.33.y.git;a=commit;h=6fb037c2ed8378c7ab0c1e00536ba6b2a866503e >>> >> >> After checking some more... >> >> I see the revert of the broken patch was done in 2.6.34.3 and a set >> of ssb patches replacing it... >> >> but it didn't happend for 2.6.33.y > > Yeah, I think I "dropped" support for .33 by then and I really didn't > care anymore. > Yep. final 2.6.33.7 was released 8 days before 2.6.34.3. > Note, I have gotten a few rumblings that I should bring .33 back to life > for some loving due to a few distros relying on it, but I need to find > the time in my schedule to do so... > Well, if you dont want to really bring it back to life, I'd suggest to simply released a 2.6.33.8 with only reverting the broken patch as it would "unbreak" the tree and call it a day :-) Otherwise... I now have merged the ssb fixes from 26.34.3: 19bfed793ee38ce027326a3c518ff6201f673a8d ssb: do not read SPROM if it does not exist 3ca696ca403b2715018bd5c693ab105c3a3ea888 ssb: Look for SPROM at different offset on higher rev CC a8515c84db1a9c9be19d8d873b059473474b6dab ssb: fix NULL ptr deref when pcihost_wrapper is used 8235ddc2cd7a3367b688e0ed52ab377eac6cfad4 ssb: Handle alternate SSPROM location into 2.6.33.7 after reverting the broken commit and have confirmation from users that it still works, so thats what I'll do for Mandriva 2010.1 -- Thomas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [33-stable regression ssb/broadcom] 2010-09-15 9:54 ` Thomas Backlund @ 2010-09-15 10:02 ` Krzysztof Olędzki 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Olędzki @ 2010-09-15 10:02 UTC (permalink / raw) To: Thomas Backlund Cc: Greg KH, stable@kernel.org, John W. Linville, David Miller, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org On 2010-09-15 11:54, Thomas Backlund wrote: > Greg KH skrev 14.9.2010 00:01: >> On Mon, Sep 13, 2010 at 11:41:23PM +0300, Thomas Backlund wrote: >>> Thomas Backlund skrev 13.9.2010 23:34: >>>> John W. Linville skrev 13.9.2010 22:36: >>>>> On Mon, Sep 13, 2010 at 12:23:29PM -0700, David Miller wrote: >>>>>> From: Thomas Backlund<tmb@mandriva.org> >>>>>> Date: Mon, 13 Sep 2010 20:38:26 +0300 >>>>>> >>>>>>> In Mandriva 2010.1 we noticed that 2.6.33.7 broke ssb/Broadcom lan for >>>>>>> several users... >>>>>>> >>>>>>> Issue is tracked at: >>>>>>> https://qa.mandriva.com/show_bug.cgi?id=60968 >>>>>>> >>>>>>> Reverting the commit restores a working lan. >>>>>>> >>>>>>> The offending commit is: >>>>>> >>>>>> Please always CC: netdev on networking reports, otherwise you are >>>>>> very unlikely to get any experts looking into your issue. >>>>> >>>>> IIRC, there was a bad patch that got sent for the 2.6.33.y series. >>>>> I thought it had been reverted or fixed already? >>>>> >>>> >>>> Nope. >>>> >>>> It got added in 2.6.33.7 >>>> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.33.y.git;a=commit;h=6fb037c2ed8378c7ab0c1e00536ba6b2a866503e >>>> >>> >>> After checking some more... >>> >>> I see the revert of the broken patch was done in 2.6.34.3 and a set >>> of ssb patches replacing it... >>> >>> but it didn't happend for 2.6.33.y >> >> Yeah, I think I "dropped" support for .33 by then and I really didn't >> care anymore. >> > > Yep. > final 2.6.33.7 was released 8 days before 2.6.34.3. > >> Note, I have gotten a few rumblings that I should bring .33 back to life >> for some loving due to a few distros relying on it, but I need to find >> the time in my schedule to do so... >> > > Well, > if you dont want to really bring it back to life, I'd suggest to simply > released a 2.6.33.8 with only reverting the broken patch as it would > "unbreak" the tree and call it a day :-) > > Otherwise... > I now have merged the ssb fixes from 26.34.3: > 19bfed793ee38ce027326a3c518ff6201f673a8d ssb: do not read SPROM if it > does not exist > 3ca696ca403b2715018bd5c693ab105c3a3ea888 ssb: Look for SPROM at > different offset on higher rev CC > a8515c84db1a9c9be19d8d873b059473474b6dab ssb: fix NULL ptr deref when > pcihost_wrapper is used > 8235ddc2cd7a3367b688e0ed52ab377eac6cfad4 ssb: Handle alternate SSPROM > location > > into 2.6.33.7 after reverting the broken commit and have confirmation > from users that it still works, so thats what I'll do for Mandriva 2010.1 If a new 2.6.33-stable kernel is going to be release there is one more important bugfix worth to be backported: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=719f835853a92f6090258114a72ffe41f09155cd This bug is present in 2.6.33, 2.6.34 and 2.6.35. Best regards, Krzysztof Olędzki ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-09-15 10:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4C8E6192.2010003@mandriva.org>
2010-09-13 19:23 ` [33-stable regression ssb/broadcom] David Miller
2010-09-13 19:36 ` John W. Linville
2010-09-13 20:34 ` Thomas Backlund
2010-09-13 20:41 ` Thomas Backlund
2010-09-13 21:01 ` Greg KH
2010-09-15 9:54 ` Thomas Backlund
2010-09-15 10:02 ` Krzysztof Olędzki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).