From: David Miller <davem@davemloft.net>
To: jdelvare@suse.de
Cc: jeffrey.t.kirsher@intel.com, bruce.w.allan@intel.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] e1000e: Simplify MSI interrupt testing
Date: Mon, 13 Sep 2010 20:13:40 -0700 (PDT) [thread overview]
Message-ID: <20100913.201340.68129542.davem@davemloft.net> (raw)
In-Reply-To: <201009131045.40018.jdelvare@suse.de>
From: Jean Delvare <jdelvare@suse.de>
Date: Mon, 13 Sep 2010 10:45:39 +0200
> The code is quite convoluted, simplify it. This also avoids calling
> e1000_request_irq() without testing the value it returned, which was
> bad.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Bruce Allan <bruce.w.allan@intel.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> I understand that we need to request the IRQ again after testing, but
> why doing it twice?
>
> I sent this patch to the e1000-devel list on August 26th, 2010, but
> didn't receive any answer:
> http://sourceforge.net/mailarchive/forum.php?thread_name=201008261445.44334.jdelvare%40suse.de&forum_name=e1000-devel
Intel folks, please provide feedback or else I'll just blindly apply Jean's
patch to the net-next-2.6 tree as long as it compiles ;-)
next prev parent reply other threads:[~2010-09-14 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:45 [PATCH] e1000e: Simplify MSI interrupt testing Jean Delvare
2010-09-14 3:13 ` David Miller [this message]
2010-09-14 5:20 ` Jeff Kirsher
2010-09-14 6:34 ` Jeff Kirsher
2010-09-14 21:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913.201340.68129542.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bruce.w.allan@intel.com \
--cc=jdelvare@suse.de \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).