From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] e1000e: Simplify MSI interrupt testing Date: Mon, 13 Sep 2010 20:13:40 -0700 (PDT) Message-ID: <20100913.201340.68129542.davem@davemloft.net> References: <201009131045.40018.jdelvare@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jeffrey.t.kirsher@intel.com, bruce.w.allan@intel.com, netdev@vger.kernel.org To: jdelvare@suse.de Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38668 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107Ab0INDN1 (ORCPT ); Mon, 13 Sep 2010 23:13:27 -0400 In-Reply-To: <201009131045.40018.jdelvare@suse.de> Sender: netdev-owner@vger.kernel.org List-ID: From: Jean Delvare Date: Mon, 13 Sep 2010 10:45:39 +0200 > The code is quite convoluted, simplify it. This also avoids calling > e1000_request_irq() without testing the value it returned, which was > bad. > > Signed-off-by: Jean Delvare > Cc: Bruce Allan > Cc: Jeff Kirsher > --- > I understand that we need to request the IRQ again after testing, but > why doing it twice? > > I sent this patch to the e1000-devel list on August 26th, 2010, but > didn't receive any answer: > http://sourceforge.net/mailarchive/forum.php?thread_name=201008261445.44334.jdelvare%40suse.de&forum_name=e1000-devel Intel folks, please provide feedback or else I'll just blindly apply Jean's patch to the net-next-2.6 tree as long as it compiles ;-)