From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC PATCH 1/4] Add a new API to virtio-pci Date: Mon, 13 Sep 2010 11:04:15 +0200 Message-ID: <20100913090415.GB29333@redhat.com> References: <20100908072859.23769.97363.sendpatchset@krkumar2.in.ibm.com> <201009091319.40274.rusty@rustcorp.com.au> <201009092144.26484.rusty@rustcorp.com.au> <20100912114637.GB22982@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: anthony@codemonkey.ws, davem@davemloft.net, kvm@vger.kernel.org, netdev@vger.kernel.org, Rusty Russell To: Krishna Kumar2 Return-path: Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Sep 13, 2010 at 09:50:42AM +0530, Krishna Kumar2 wrote: > "Michael S. Tsirkin" wrote on 09/12/2010 05:16:37 PM: > > > "Michael S. Tsirkin" > > 09/12/2010 05:16 PM > > > > On Thu, Sep 09, 2010 at 07:19:33PM +0530, Krishna Kumar2 wrote: > > > Unfortunately I need a > > > constant in vhost for now. > > > > Maybe not even that: you create multiple vhost-net > > devices so vhost-net in kernel does not care about these > > either, right? So this can be just part of vhost_net.h > > in qemu. > > Sorry, I didn't understand what you meant. > > I can remove all socks[] arrays/constants by pre-allocating > sockets in vhost_setup_vqs. Then I can remove all "socks" > parameters in vhost_net_stop, vhost_net_release and > vhost_net_reset_owner. > > Does this make sense? > > Thanks, > > - KK Here's what I mean: each vhost device includes 1 TX and 1 RX VQ. Instead of teaching vhost about multiqueue, we could simply open /dev/vhost-net multiple times. How many times would be up to qemu. -- MST