From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: andy@greyhouse.net, netdev@vger.kernel.org,
alexander.h.duyck@intel.com, jesse.brandeburg@intel.com,
stable@kernel.org
Subject: Re: [PATCH net-2.6 v2] bonding: correctly process non-linear skbs
Date: Tue, 14 Sep 2010 14:26:05 -0700 (PDT) [thread overview]
Message-ID: <20100914.142605.108789529.davem@davemloft.net> (raw)
In-Reply-To: <19704.1284167315@death>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 10 Sep 2010 18:08:35 -0700
> Andy Gospodarek <andy@greyhouse.net> wrote:
>>[PATCH net-2.6 v2] bonding: correctly process non-linear skbs
>>
>>It was recently brought to my attention that 802.3ad mode bonds would no
>>longer form when using some network hardware after a driver update.
>>After snooping around I realized that the particular hardware was using
>>page-based skbs and found that skb->data did not contain a valid LACPDU
>>as it was not stored there. That explained the inability to form an
>>802.3ad-based bond. For balance-alb mode bonds this was also an issue
>>as ARPs would not be properly processed.
>>
>>This patch fixes the issue in my tests and should be applied to 2.6.36
>>and as far back as anyone cares to add it to stable.
>>
>>Thanks to Alexander Duyck <alexander.h.duyck@intel.com> and Jesse
>>Brandeburg <jesse.brandeburg@intel.com> for the suggestions on this one.
>>
>>Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
>>CC: Alexander Duyck <alexander.h.duyck@intel.com>
>>CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
>>CC: stable@kerne.org
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>
Applied, thanks everyone.
prev parent reply other threads:[~2010-09-14 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 20:38 [PATCH net-2.6] bonding: correctly process LACPDUs in non-linear skbs Andy Gospodarek
2010-09-10 21:04 ` Jay Vosburgh
2010-09-10 21:43 ` [PATCH net-2.6 v2] bonding: correctly process " Andy Gospodarek
2010-09-11 1:08 ` Jay Vosburgh
2010-09-14 21:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914.142605.108789529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).