From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: jdelvare@suse.de, bruce.w.allan@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH] e1000e: Simplify MSI interrupt testing
Date: Tue, 14 Sep 2010 14:29:49 -0700 (PDT) [thread overview]
Message-ID: <20100914.142949.184836973.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikhxka-HHX+SWMpXHcANZCMzedEz+XyiwmF48AK@mail.gmail.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 13 Sep 2010 23:34:54 -0700
> On Mon, Sep 13, 2010 at 01:45, Jean Delvare <jdelvare@suse.de> wrote:
>> The code is quite convoluted, simplify it. This also avoids calling
>> e1000_request_irq() without testing the value it returned, which was
>> bad.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Bruce Allan <bruce.w.allan@intel.com>
>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> FYI - Emil tested this while I was out, and all was good. Sorry for
> the delayed response Jean.
Applied, thanks a lot.
prev parent reply other threads:[~2010-09-14 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:45 [PATCH] e1000e: Simplify MSI interrupt testing Jean Delvare
2010-09-14 3:13 ` David Miller
2010-09-14 5:20 ` Jeff Kirsher
2010-09-14 6:34 ` Jeff Kirsher
2010-09-14 21:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914.142949.184836973.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bruce.w.allan@intel.com \
--cc=jdelvare@suse.de \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).