From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] e1000e: Simplify MSI interrupt testing Date: Tue, 14 Sep 2010 14:29:49 -0700 (PDT) Message-ID: <20100914.142949.184836973.davem@davemloft.net> References: <201009131045.40018.jdelvare@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jdelvare@suse.de, bruce.w.allan@intel.com, netdev@vger.kernel.org To: jeffrey.t.kirsher@intel.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:52921 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930Ab0INV3b (ORCPT ); Tue, 14 Sep 2010 17:29:31 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jeff Kirsher Date: Mon, 13 Sep 2010 23:34:54 -0700 > On Mon, Sep 13, 2010 at 01:45, Jean Delvare wrote: >> The code is quite convoluted, simplify it. This also avoids calling >> e1000_request_irq() without testing the value it returned, which was >> bad. >> >> Signed-off-by: Jean Delvare >> Cc: Bruce Allan > > Acked-by: Jeff Kirsher > > FYI - Emil tested this while I was out, and all was good. Sorry for > the delayed response Jean. Applied, thanks a lot.