From: David Miller <davem@davemloft.net>
To: simon@sequanux.org
Cc: netdev@vger.kernel.org, sguinot@lacie.com
Subject: Re: [PATCH] phylib: fix PAL state machine restart on resume
Date: Tue, 14 Sep 2010 14:31:15 -0700 (PDT) [thread overview]
Message-ID: <20100914.143115.124060138.davem@davemloft.net> (raw)
In-Reply-To: <1284451921-9937-1-git-send-email-simon@sequanux.org>
From: Simon Guinot <simon@sequanux.org>
Date: Tue, 14 Sep 2010 10:12:01 +0200
> From: Simon Guinot <sguinot@lacie.com>
>
> On resume, before starting the PAL state machine, check if the
> adjust_link() method is well supplied. If not, this would lead to a
> NULL pointer dereference in the phy_state_machine() function.
>
> This scenario can happen if the Ethernet driver call manually the PHY
> functions instead of using the PAL state machine. The mv643xx_eth driver
> is a such example.
>
> Signed-off-by: Simon Guinot <sguinot@lacie.com>
Applied, thanks.
prev parent reply other threads:[~2010-09-14 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 8:12 [PATCH] phylib: fix PAL state machine restart on resume Simon Guinot
2010-09-14 21:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914.143115.124060138.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sguinot@lacie.com \
--cc=simon@sequanux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).