From: David Miller <davem@davemloft.net>
To: daniel@gaisler.com
Cc: sparclinux@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: SPARC32 SMP 2.6.36-rc3 build error
Date: Tue, 14 Sep 2010 21:42:35 -0700 (PDT) [thread overview]
Message-ID: <20100914.214235.183040334.davem@davemloft.net> (raw)
In-Reply-To: <4C8F78F3.7020408@gaisler.com>
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Tue, 14 Sep 2010 15:30:27 +0200
> I have problems linking Linux SPARC32 when SMP is enabled:
>
> LD vmlinux
> SYSMAP System.map
> SYSMAP .tmp_System.map
> BTFIX arch/sparc/boot/btfix.S
> AS arch/sparc/boot/btfix.o
> LD arch/sparc/boot/image
> net/built-in.o: In function `net_rps_action_and_irq_enable':
> /home/daniel/linux/linux/linux-2.6/net/core/dev.c:3337: undefined
> reference to `__smp_call_function_single'
> make[1]: *** [arch/sparc/boot/image] Error 1
> make: *** [zImage] Error 2
It's a missing dependency in the networking code, I'll fix this
in the net-2.6 tree as follows:
--------------------
net: RPS needs to depend upon USE_GENERIC_SMP_HELPERS
You cannot invoke __smp_call_function_single() unless the
architecture sets this symbol.
Reported-by: Daniel Hellstrom <daniel@gaisler.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/Kconfig b/net/Kconfig
index e330594..e926884 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -217,7 +217,7 @@ source "net/dns_resolver/Kconfig"
config RPS
boolean
- depends on SMP && SYSFS
+ depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS
default y
menu "Network testing"
--
1.7.2.2
next parent reply other threads:[~2010-09-15 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C8F78F3.7020408@gaisler.com>
2010-09-15 4:42 ` David Miller [this message]
2010-09-15 7:20 ` SPARC32 SMP 2.6.36-rc3 build error Daniel Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914.214235.183040334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@gaisler.com \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).