From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
santwona.behera@sun.com, peter.p.waskiewicz.jr@intel.com
Subject: Re: [PATCH net-next-2.6 2/2] ethtool: Remove unimplemented flow specification types
Date: Wed, 15 Sep 2010 14:41:52 -0700 (PDT) [thread overview]
Message-ID: <20100915.144152.91337452.davem@davemloft.net> (raw)
In-Reply-To: <1284491588.2289.8.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 14 Sep 2010 20:13:08 +0100
> struct ethtool_rawip4_spec and struct ethtool_ether_spec are neither
> commented nor used by any driver, so remove them. Adjust padding in
> the user-visible unions that included these structures.
>
> Fix references to struct ethtool_rawip4_spec in
> ethtool_get_rx_ntuple(), which should use struct ethtool_usrip4_spec.
>
> struct ethtool_usrip4_spec cannot hold IPv6 host addresses and there
> is no separate structure that can, so remove ETH_RX_NFC_IP6 and the
> reference to it in niu.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Yeah. The NIU chip's TCAM can only match on 32-bits (I think the
least significant) of the IPV6 address since that's how many bits
it has in the TCAM entries for addreses and address masks.
I'll apply this, thanks.
next prev parent reply other threads:[~2010-09-15 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 19:10 [PATCHv2 net-next-2.6 1/2] ethtool: Complete kernel-doc comments for RX flow filter and hash control Ben Hutchings
2010-09-14 19:13 ` [PATCH net-next-2.6 2/2] ethtool: Remove unimplemented flow specification types Ben Hutchings
2010-09-15 21:41 ` David Miller [this message]
2010-09-15 21:42 ` [PATCHv2 net-next-2.6 1/2] ethtool: Complete kernel-doc comments for RX flow filter and hash control David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915.144152.91337452.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=santwona.behera@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).