From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6 3/3] gre: get rid of ipgre_lock Date: Wed, 15 Sep 2010 19:31:09 -0700 (PDT) Message-ID: <20100915.193109.123984678.davem@davemloft.net> References: <1284584873.2462.71.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: eric.dumazet@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58329 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474Ab0IPCav (ORCPT ); Wed, 15 Sep 2010 22:30:51 -0400 In-Reply-To: <1284584873.2462.71.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Wed, 15 Sep 2010 23:07:53 +0200 > As RTNL is held while doing tunnels inserts and deletes, we can remove > ipgre_lock spinlock. My initial RCU conversion was conservative and > converted the rwlock to spinlock, with no RTNL requirement. > > Use appropriate rcu annotations and modern lockdep checks as well. > > Signed-off-by: Eric Dumazet Applied.