From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: mjg@redhat.com, netdev@vger.kernel.org, jglisse@redhat.com
Subject: Re: [PATCH] r8169: Handle rxfifo errors on 8168 chips
Date: Wed, 15 Sep 2010 19:33:45 -0700 (PDT) [thread overview]
Message-ID: <20100915.193345.184829695.davem@davemloft.net> (raw)
In-Reply-To: <20100915222719.GA13385@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 16 Sep 2010 00:27:19 +0200
> Matthew Garrett <mjg@redhat.com> :
> [...]
>> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
>> index 078bbf4..a0da4a1 100644
>> --- a/drivers/net/r8169.c
>> +++ b/drivers/net/r8169.c
> [...]
>> @@ -4625,8 +4625,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
>> }
>>
>> /* Work around for rx fifo overflow */
>> - if (unlikely(status & RxFIFOOver) &&
>> - (tp->mac_version == RTL_GIGA_MAC_VER_11)) {
>> + if (unlikely(status & RxFIFOOver)) {
>> netif_stop_queue(dev);
>> rtl8169_tx_timeout(dev);
>> break;
>
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
>
> Realtek's driver does something similar with the revision RTL_GIGA_MAC_VER_11
> of the 8168.
Applied, thanks everyone.
prev parent reply other threads:[~2010-09-16 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 21:57 [PATCH] r8169: Handle rxfifo errors on 8168 chips Matthew Garrett
2010-09-15 22:27 ` Francois Romieu
2010-09-16 2:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915.193345.184829695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jglisse@redhat.com \
--cc=mjg@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).