From: David Miller <davem@davemloft.net>
To: remi@remlab.net
Cc: netdev@vger.kernel.org, remi.denis-courmont@nokia.com
Subject: Re: [PATCH net-next-2.6] Phonet: remove dangling pipe if an endpoint is closed early
Date: Wed, 15 Sep 2010 21:35:18 -0700 (PDT) [thread overview]
Message-ID: <20100915.213518.137835427.davem@davemloft.net> (raw)
In-Reply-To: <20100915.213258.212397416.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 15 Sep 2010 21:32:58 -0700 (PDT)
> Applied.
Btw, I had to apply the following warning fix against your other
set of changes.
--------------------
phonet: Fix build warning.
net/phonet/socket.c: In function ‘pn_res_seq_show’:
net/phonet/socket.c:726: warning: format ‘%02X’ expects type ‘unsigned int’, but argument 3 has type ‘long int’
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/phonet/socket.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/phonet/socket.c b/net/phonet/socket.c
index 6bf6e3c..aca8fba 100644
--- a/net/phonet/socket.c
+++ b/net/phonet/socket.c
@@ -723,7 +723,8 @@ static int pn_res_seq_show(struct seq_file *seq, void *v)
struct sock *sk = *psk;
seq_printf(seq, "%02X %5d %lu%n",
- psk - pnres.sk, sock_i_uid(sk), sock_i_ino(sk), &len);
+ (int) (psk - pnres.sk), sock_i_uid(sk),
+ sock_i_ino(sk), &len);
}
seq_printf(seq, "%*s\n", 63 - len, "");
return 0;
--
1.7.2.2
next prev parent reply other threads:[~2010-09-16 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 22:19 [PATCH net-next-2.6] Phonet: remove dangling pipe if an endpoint is closed early Rémi Denis-Courmont
2010-09-16 4:32 ` David Miller
2010-09-16 4:35 ` David Miller [this message]
2010-09-16 4:41 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915.213518.137835427.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
--cc=remi@remlab.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).