From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brandon Philips Subject: Re: [PATCH] vlan: enable GRO if real_dev supports it Date: Wed, 15 Sep 2010 11:59:04 -0700 Message-ID: <20100915185903.GD4191@mmm.home.ifup.org> References: <20100915015052.GA6602@mmm.home.ifup.org> <20100914.213544.112598547.davem@davemloft.net> <20100915163749.GA4191@mmm.home.ifup.org> <1284570520.2462.5.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, bruce.w.allan@intel.com, alexander.h.duyck@intel.com, peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com, donald.c.skidmore@intel.com, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net To: Eric Dumazet Return-path: Received: from cantor.suse.de ([195.135.220.2]:34635 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753651Ab0IOT0a (ORCPT ); Wed, 15 Sep 2010 15:26:30 -0400 Content-Disposition: inline In-Reply-To: <1284570520.2462.5.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On 19:08 Wed 15 Sep 2010, Eric Dumazet wrote: > Le mercredi 15 septembre 2010 =E0 09:37 -0700, Brandon Philips a =E9c= rit : > > Currently vlan devices don't have GRO by default as none of the Eth= ernet > > drivers add NETIF_F_GRO to their vlan_features. > >=20 > > As GRO is a software feature just propogate GRO from the real_dev i= n the > > vlan core. There is no need to have the drivers each add NETIF_F_GR= O to > > their vlan_features. > >=20 > > Signed-off-by: Brandon Philips > > --- > > net/8021q/vlan_dev.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > >=20 > > diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c > > index 3bccdd1..6fbc445 100644 > > --- a/net/8021q/vlan_dev.c > > +++ b/net/8021q/vlan_dev.c > > @@ -735,6 +735,7 @@ static int vlan_dev_init(struct net_device *dev= ) > > (1<<__LINK_STATE_DORMANT))) | > > (1<<__LINK_STATE_PRESENT); > > =20 > > + dev->features |=3D real_dev->features & NETIF_F_GRO; > > dev->features |=3D real_dev->features & real_dev->vlan_features; > > dev->gso_max_size =3D real_dev->gso_max_size; > > =20 >=20 > Hmm, this is only part of a generic solution. >=20 > If I enable gro with "ethtool -K eth0 gro on", should we propagate GR= O > on vlan eth0.555 ? That works fine as far as I can see. I don't think it should go the other way though.=20 Cheers, Brandon