From: David Miller <davem@davemloft.net>
To: somnath.kotur@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net-2.6 be2net: fix to get RX IDs 0 and 1
Date: Thu, 16 Sep 2010 21:50:56 -0700 (PDT) [thread overview]
Message-ID: <20100916.215056.133407514.davem@davemloft.net> (raw)
In-Reply-To: <20100916113842.GA3937@serverengines.com>
From: Somnath Kotur <somnath.kotur@emulex.com>
Date: Thu, 16 Sep 2010 17:09:02 +0530
> Change made to allocate RX IDs 0 and 1 for the two ports.
> To get RX Q IDs 0 and 1 enable RSS Capability for that interface.
> RX IDs 0 and 1 have 32 bit drop counters which will take a long time
> to wrap around thereby presenting a consistent stats display.
>
> Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
I don't understand this commit message at all.
The patch looks like it's simply respecting capability flags
stored in the chip, and thus will now enable RSS on more
interfaces than it did before.
And that has absolutely nothing to do with allocating specific
RX IDs or anything like that.
It also, therefore, has nothing to do with fixing any kind of
serious regression in this driver. Therefore this patch is
absolutely not appropriate for net-2.6
Please give a more accurate and understandable commit message
for this patch, and target it for net-next-2.6 unless you can
show that this fixes a very serious bug in 2.6.36
prev parent reply other threads:[~2010-09-17 4:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 11:39 [PATCH] net-2.6 be2net: fix to get RX IDs 0 and 1 Somnath Kotur
2010-09-17 4:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916.215056.133407514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=somnath.kotur@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).