From: David Miller <davem@davemloft.net>
To: drosenberg@vsecurity.com
Cc: j.dumon@option.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, security@kernel.org, stable@kernel.org
Subject: Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory
Date: Thu, 16 Sep 2010 21:55:35 -0700 (PDT) [thread overview]
Message-ID: <20100916.215535.128594045.davem@davemloft.net> (raw)
In-Reply-To: <1284587008.6275.95.camel@dan>
From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Wed, 15 Sep 2010 17:43:28 -0400
> Fixed formatting (tabs and line breaks).
>
> The TIOCGICOUNT device ioctl allows unprivileged users to read
> uninitialized stack memory, because the "reserved" member of the
> serial_icounter_struct struct declared on the stack in hso_get_count()
> is not altered or zeroed before being copied back to the user. This
> patch takes care of it.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Applied.
prev parent reply other threads:[~2010-09-17 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 21:43 [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory Dan Rosenberg
2010-09-16 15:57 ` Steven Rostedt
2010-09-16 17:07 ` Alan Cox
2010-09-16 16:52 ` Steven Rostedt
2010-09-16 17:47 ` Alan Cox
2010-09-16 17:36 ` Steven Rostedt
2010-09-17 4:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916.215535.128594045.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).