From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, js@sig21.net, deepak.sikri@st.com
Subject: Re: [net-next 2/4] stmmac: consolidate and tidy-up the COE support
Date: Fri, 17 Sep 2010 16:13:25 -0700 (PDT) [thread overview]
Message-ID: <20100917.161325.179286731.davem@davemloft.net> (raw)
In-Reply-To: <1284729822-29176-2-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Fri, 17 Sep 2010 15:23:40 +0200
> The first version of the driver had hard-coded the logic
> for handling the checksum offloading.
> This was designed according to the chips included in
> the STM platforms where:
> o MAC10/100 supports no COE at all.
> o GMAC fully supports RX/TX COE.
>
> This is not good for other chip configurations where,
> for example, the mac10/100 supports the tx csum in HW
> or when the GMAC has no IPC.
>
> Thanks to Johannes Stezenbach; he provided me a first
> draft of this patch that only reviewed the IPC for the
> GMAC devices.
>
> This patch also helps on SPEAr platforms where the
> MAC10/100 can perform the TX csum in HW.
> Thanks to Deepak SIKRI for his support on this.
>
> In the end, GMAC devices for STM platforms have
> a bugged Jumbo frame support that needs to have
> the Tx COE disabled for oversized frames (due to
> limited buffer sizes). This information is also
> passed through the driver's platform structure.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Signed-off-by: Johannes Stezenbach <js@sig21.net>
> Signed-off-by: Deepak SIKRI <deepak.sikri@st.com>
Applied.
next prev parent reply other threads:[~2010-09-17 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 13:23 [net-next 1/4] stmmac: add CSR Clock range selection Giuseppe CAVALLARO
2010-09-17 13:23 ` [net-next 2/4] stmmac: consolidate and tidy-up the COE support Giuseppe CAVALLARO
2010-09-17 13:23 ` [net-next 3/4] stmmac: prevent dma init stuck in case of failures Giuseppe CAVALLARO
2010-09-17 13:23 ` [net-next 4/4] stmmac: use one memset() to reset TDES01 Giuseppe CAVALLARO
2010-09-17 23:13 ` David Miller
2010-09-17 23:13 ` [net-next 3/4] stmmac: prevent dma init stuck in case of failures David Miller
2010-09-17 23:13 ` David Miller [this message]
2010-09-17 23:13 ` [net-next 1/4] stmmac: add CSR Clock range selection David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917.161325.179286731.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=deepak.sikri@st.com \
--cc=js@sig21.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).