From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: peter.p.waskiewicz.jr@intel.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com,
e1000-devel@lists.sourceforge.net, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
alexander.h.duyck@intel.com, john.ronciak@intel.com
Subject: Re: [PATCH net-next-2.6 1/2] ethtool, ixgbe: Move RX n-tuple mask fixup to ethtool
Date: Fri, 17 Sep 2010 16:53:41 -0700 (PDT) [thread overview]
Message-ID: <20100917.165341.140752835.davem@davemloft.net> (raw)
In-Reply-To: <1284672488.2283.33.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 16 Sep 2010 22:28:07 +0100
> The ethtool utility does not set masks for flow parameters that are
> not specified, so if both value and mask are 0 then this must be
> treated as equivalent to a mask with all bits set. Currently that is
> done in the only driver that implements RX n-tuple filtering, ixgbe.
> Move it to the ethtool core.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Looks good to me, applied, thanks Ben.
prev parent reply other threads:[~2010-09-17 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 21:28 [PATCH net-next-2.6 1/2] ethtool, ixgbe: Move RX n-tuple mask fixup to ethtool Ben Hutchings
2010-09-17 23:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917.165341.140752835.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).