From: David Miller <davem@davemloft.net>
To: hramrach@centrum.cz
Cc: herbert@gondor.apana.org.au, akpm@linux-foundation.org,
netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 18492] New: kernel softirq warning on boot
Date: Fri, 17 Sep 2010 16:55:36 -0700 (PDT) [thread overview]
Message-ID: <20100917.165536.254856822.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTinyhM30KV+Etg2qDzEoqOjcPj7gv5EkPbknxYVQ@mail.gmail.com>
From: Michal Suchanek <hramrach@centrum.cz>
Date: Fri, 17 Sep 2010 20:00:42 +0200
> On 15 September 2010 08:46, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> On Tue, Sep 14, 2010 at 02:11:03PM -0700, David Miller wrote:
>>>
>>> I'll take a closer look at this if Herbert doesn't beat me to it.
>>
>> I thought we were going to use this patch until Paul's BH warning
>> removal made it into mainline?
>>
>> netpoll: Disable IRQ around RCU dereference in netpoll_rx
>>
>> We cannot use rcu_dereference_bh safely in netpoll_rx as we may
>> be called with IRQs disabled. We could however simply disable
>> IRQs as that too causes BH to be disabled and is safe in either
>> case.
>>
>> Thanks to John Linville for discovering this bug and providing
>> a patch.
>>
> With the patch applied I no longet get the warning.
Ok I'll toss this upstream since I have no indication that Paul's
RCU change will hit Linus's tree any time soon.
Thanks.
prev parent reply other threads:[~2010-09-17 23:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-18492-10286@https.bugzilla.kernel.org/>
2010-09-14 19:07 ` [Bugme-new] [Bug 18492] New: kernel softirq warning on boot Andrew Morton
2010-09-14 20:45 ` Michal Suchanek
2010-09-14 20:57 ` Andrew Morton
2010-09-14 21:11 ` David Miller
2010-09-15 6:46 ` Herbert Xu
2010-09-16 4:40 ` David Miller
2010-09-17 18:00 ` Michal Suchanek
2010-09-17 23:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917.165536.254856822.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hramrach@centrum.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).