From: Willy Tarreau <w@1wt.eu>
To: David Miller <davem@davemloft.net>
Cc: drosenberg@vsecurity.com, security@kernel.org,
grundler@parisc-linux.org, netdev@vger.kernel.org,
jeffm@suse.com, linux-kernel@vger.kernel.org, kyle@mcmartin.ca
Subject: Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
Date: Fri, 17 Sep 2010 08:36:02 +0200 [thread overview]
Message-ID: <20100917063602.GA2341@1wt.eu> (raw)
In-Reply-To: <20100916.223441.93463391.davem@davemloft.net>
On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote:
> From: Dan Rosenberg <drosenberg@vsecurity.com>
> Date: Fri, 17 Sep 2010 01:30:36 -0400
>
> > Tiring doesn't begin to describe it. Formatting undamaged.
>
> :-) Thanks.
>
> > This was previously reported as a security issue due to leakage of
> > uninitialized stack memory. Jeff Mahoney pointed out that this is
> > incorrect since the copied data is from a union (rather than a struct).
> > Therefore, this patch is only under consideration for the sake of
> > correctness, and is not security relevant.
> >
> > Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> > Acked-by: Grant Grundler <grundler@parisc-linux.org>
>
> Applied.
David, just for the record, as was already reported on the list, this
fix is finally more a cleanup than a security fix because "tmp" is a
union and not a struct, so tmp.addr == tmp.lval.
Regards,
Willy
next prev parent reply other threads:[~2010-09-17 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 21:43 [PATCH v2] drivers/net/tulip/de4x5.c Dan Rosenberg
2010-09-17 4:53 ` David Miller
2010-09-17 5:05 ` [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl Dan Rosenberg
2010-09-17 5:27 ` David Miller
2010-09-17 5:30 ` [PATCH v4] " Dan Rosenberg
2010-09-17 5:34 ` David Miller
2010-09-17 6:36 ` Willy Tarreau [this message]
2010-09-17 6:37 ` [Security] " Willy Tarreau
2010-09-17 6:53 ` David Miller
2010-09-17 5:31 ` [PATCH v3] " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917063602.GA2341@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=grundler@parisc-linux.org \
--cc=jeffm@suse.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).