netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch -next] rds: double unlock in rds_ib_cm_handle_connect()
@ 2010-09-18 23:42 Dan Carpenter
  2010-09-19 18:59 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-09-18 23:42 UTC (permalink / raw)
  To: Andy Grover
  Cc: David S. Miller, Zach Brown, Julia Lawall, Tejun Heo, rds-devel,
	netdev, kernel-janitors

We unlock after we goto out.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index bc3dbc1..ee369d2 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -521,7 +521,6 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
 	err = rds_ib_setup_qp(conn);
 	if (err) {
 		rds_ib_conn_error(conn, "rds_ib_setup_qp failed (%d)\n", err);
-		mutex_unlock(&conn->c_cm_lock);
 		goto out;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-19 18:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-18 23:42 [patch -next] rds: double unlock in rds_ib_cm_handle_connect() Dan Carpenter
2010-09-19 18:59 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).