From: David Miller <davem@davemloft.net>
To: gregory.v.rose@intel.com
Cc: error27@gmail.com, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ixgbevf: potential NULL dereference on allocation failure
Date: Sun, 19 Sep 2010 11:33:47 -0700 (PDT) [thread overview]
Message-ID: <20100919.113347.39185228.davem@davemloft.net> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755F66821BC@orsmsx508.amr.corp.intel.com>
From: "Rose, Gregory V" <gregory.v.rose@intel.com>
Date: Tue, 14 Sep 2010 09:57:46 -0700
> I've taken up your suggestions and implemented them (roughly) as
> suggested below. After looking at the code I had to agree that it
> would be very confusing for a user to set new ring parameters, have
> the call partially succeed but get no error and then look at the
> parameters again and not see what he expected. Now the code will do
> as suggested and just unwind all prior allocations and return an
> error if the new ring sizing didn't work. The user will be left
> with the prior ring size allocations which is probably what he would
> expect.
>
> The patch is going to be posted internally and after it goes through
> our review process it will be posted to netdev.
Thanks for doing this work Greg.
prev parent reply other threads:[~2010-09-19 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 11:52 [patch] ixgbevf: potential NULL dereference on allocation failure Dan Carpenter
2010-09-10 20:21 ` David Miller
2010-09-10 20:25 ` Rose, Gregory V
2010-09-14 16:57 ` Rose, Gregory V
2010-09-19 18:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100919.113347.39185228.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).