From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: herbert@gondor.apana.org.au, thomas.egerer@secunet.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: Allow different selector family in temporary state
Date: Mon, 20 Sep 2010 11:11:49 -0700 (PDT) [thread overview]
Message-ID: <20100920.111149.45908739.davem@davemloft.net> (raw)
In-Reply-To: <20100920115253.GG4134@gauss.secunet.de>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 20 Sep 2010 13:52:53 +0200
> From: Thomas Egerer <thomas.egerer@secunet.com>
>
> The family parameter xfrm_state_find is used to find a state matching a
> certain policy. This value is set to the template's family
> (encap_family) right before xfrm_state_find is called.
> The family parameter is however also used to construct a temporary state
> in xfrm_state_find itself which is wrong for inter-family scenarios
> because it produces a selector for the wrong family. Since this selector
> is included in the xfrm_user_acquire structure, user space programs
> misinterpret IPv6 addresses as IPv4 and vice versa.
> This patch splits up the original init_tempsel function into a part that
> initializes the selector respectively the props and id of the temporary
> state, to allow for differing ip address families whithin the state.
>
> Signed-off-by: Thomas Egerer <thomas.egerer@secunet.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Looks good, applied, thanks a lot.
prev parent reply other threads:[~2010-09-20 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 11:52 [PATCH] xfrm: Allow different selector family in temporary state Steffen Klassert
2010-09-20 18:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920.111149.45908739.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=thomas.egerer@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).