From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: tdm.code@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix race in tcp_poll
Date: Mon, 20 Sep 2010 15:42:41 -0700 (PDT) [thread overview]
Message-ID: <20100920.154241.183059064.davem@davemloft.net> (raw)
In-Reply-To: <1285019646.2323.267.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 20 Sep 2010 23:54:06 +0200
> Le lundi 20 septembre 2010 à 12:18 -0700, Tom Marshall a écrit :
>> If a RST comes in immediately after checking sk->sk_err, tcp_poll will
>> return POLLIN but not POLLOUT. Fix this by checking sk->sk_err at the end
>> of tcp_poll. Additionally, ensure the correct order of operations on SMP
>> machines with memory barriers.
>>
>> Signed-off-by: Tom Marshall <tdm.code@gmail.com>
...
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Maybe this is the last time we can avoid taking socket lock in
> tcp_poll() ;)
:-) Applied, thanks everyone.
prev parent reply other threads:[~2010-09-20 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 19:18 [PATCH] Fix race in tcp_poll Tom Marshall
2010-09-20 21:54 ` Eric Dumazet
2010-09-20 22:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920.154241.183059064.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tdm.code@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).