From: Nick Bowler <nbowler@elliptictech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Regression, bisected: reference leak with IPSec since ~2.6.31
Date: Mon, 20 Sep 2010 15:52:56 -0400 [thread overview]
Message-ID: <20100920195256.GA14330@elliptictech.com> (raw)
In-Reply-To: <1285006844.2323.17.camel@edumazet-laptop>
On 2010-09-20 20:20 +0200, Eric Dumazet wrote:
> If you change your program to send small frames (so they are not
> fragmented), is the problem still present ?
I changed MAX_DGRAM_SIZE in the test program to 1000 (mtu on the
interface is 1500). The short answer is that the references are
not leaked, and things seem to get cleaned up. So the rest of this
mail probably describes a separate issue.
The long answer, however, is interesting: With latest Linus' git, the
references are cleaned up much later than I would expect. After running
the test program and flushing the SAD/SPD, the reference count is still
1. If I repeat the test immediately, the reference count will increase
further. I can easily raise the reference count to, say, 100. Now, if
I wait a while (10 minutes or so), the reference count will still be
100. However, when I run the setkey script after this delay, the
reference count drops immediately to 1. If I then flush the SAD/SPD, it
drops to 0.
This behaviour is new: newer than the reported leak. For example, with
2.6.34, everything works perfectly with MAX_DGRAM_SIZE set to 1000 (the
SAs are destroyed immediately when the SAD/SPD are flushed), but the
leak occurs with MAX_DGRAM_SIZE set to 10000.
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2010-09-20 19:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 17:44 Regression, bisected: reference leak with IPSec since ~2.6.31 Nick Bowler
2010-09-20 18:20 ` Eric Dumazet
2010-09-20 19:52 ` Nick Bowler [this message]
2010-09-20 20:00 ` David Miller
2010-09-20 21:23 ` Nick Bowler
2010-09-20 20:17 ` Eric Dumazet
2010-09-20 21:31 ` Eric Dumazet
2010-09-21 6:16 ` [PATCH] ip : take care of last fragment in ip_append_data Eric Dumazet
2010-09-21 23:38 ` David Miller
2010-09-22 4:44 ` Eric Dumazet
2010-09-22 4:53 ` David Miller
2010-09-24 21:42 ` David Miller
2010-09-21 9:12 ` Regression, bisected: reference leak with IPSec since ~2.6.31 Jarek Poplawski
2010-09-21 9:21 ` Eric Dumazet
2010-09-21 9:38 ` Jarek Poplawski
2010-09-21 9:55 ` Eric Dumazet
2010-09-21 10:07 ` Eric Dumazet
2010-09-21 10:48 ` Jarek Poplawski
2010-09-21 11:58 ` Eric Dumazet
2010-09-21 12:39 ` Jarek Poplawski
2010-09-21 14:05 ` Nick Bowler
2010-09-21 14:16 ` [PATCH] ip : fix truesize mismatch in ip fragmentation Eric Dumazet
2010-09-21 15:58 ` [PATCH v3] ip: " Eric Dumazet
2010-09-21 16:26 ` Henrique de Moraes Holschuh
2010-09-21 16:31 ` Eric Dumazet
2010-09-21 18:09 ` Henrique de Moraes Holschuh
2010-09-21 19:24 ` David Miller
2010-09-21 23:06 ` Henrique de Moraes Holschuh
2010-09-21 17:50 ` Jarek Poplawski
2010-09-21 18:47 ` Eric Dumazet
2010-09-21 19:21 ` Jarek Poplawski
2010-09-21 22:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920195256.GA14330@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).