From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value
Date: Tue, 21 Sep 2010 14:57:03 -0700 (PDT) [thread overview]
Message-ID: <20100921.145703.189694076.davem@davemloft.net> (raw)
In-Reply-To: <1285009546.2282.126.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 20 Sep 2010 20:05:46 +0100
> If RPS is enabled there's a separate kobject for each RX queue. Those
> other drivers probably should be setting it.
>
> Oh, but this only exists if CONFIG_RPS is enabled. I think we need an
> inline function for setting this.
It's set in the core by alloc_netdev_mq(), you should never have to
set this in your driver.
And that also takes care of the CONFIG_RPS dependency in one spot,
another good argument for drivers never touching this value.
I'm not applying this patch.
next prev parent reply other threads:[~2010-09-21 21:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 18:40 [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 Ben Hutchings
2010-09-20 18:41 ` [PATCH net-next-2.6 1/8] ethtool: Define RX n-tuple action to clear a rule Ben Hutchings
2010-09-20 18:42 ` [PATCH net-next-2.6 2/8] ethtool: Add Ethernet MAC-level filtering/steering Ben Hutchings
2010-09-20 18:42 ` [PATCH net-next-2.6 3/8] ethtool: Allocate register dump buffer with vmalloc() Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 4/8] sfc: Add filter table management Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 5/8] sfc: Implement the ethtool RX n-tuple control functions Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 6/8] sfc: Include RX IP filter table in register dump Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value Ben Hutchings
2010-09-20 18:54 ` Eric Dumazet
2010-09-20 19:05 ` Ben Hutchings
2010-09-21 21:57 ` David Miller [this message]
2010-09-22 1:31 ` Ben Hutchings
2010-09-22 1:38 ` David Miller
2010-09-22 15:28 ` Ben Hutchings
2010-09-22 15:44 ` Eric Dumazet
2010-09-20 18:44 ` [PATCH net-next-2.6 8/8] sfc: Clean up and correct comments on efx_monitor() Ben Hutchings
2010-09-21 21:58 ` [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 David Miller
2010-09-21 23:23 ` David Miller
2010-09-22 15:27 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921.145703.189694076.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).