netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tmspci: fix tr%d in printk
@ 2010-09-21  7:19 Meelis Roos
  2010-09-22  1:06 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Meelis Roos @ 2010-09-21  7:19 UTC (permalink / raw)
  To: netdev

tmspci driver uses dev->name before register_netdev() and so prints tr%d 
in initialization messages. Fix it by using dev_info.

Found and tested on real hardware.

Signed-off-by: Meelis Roos <mroos@linux.ee>

diff --git a/drivers/net/tokenring/tmspci.c b/drivers/net/tokenring/tmspci.c
index d4c7c0c..d3e788a 100644
--- a/drivers/net/tokenring/tmspci.c
+++ b/drivers/net/tokenring/tmspci.c
@@ -125,18 +125,16 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic
 	dev->irq 	= pci_irq_line;
 	dev->dma	= 0;
 
-	printk("%s: %s\n", dev->name, cardinfo->name);
-	printk("%s:    IO: %#4lx  IRQ: %d\n",
-	       dev->name, dev->base_addr, dev->irq);
+	dev_info(&pdev->dev, "%s\n", cardinfo->name);
+	dev_info(&pdev->dev, "    IO: %#4lx  IRQ: %d\n", dev->base_addr, dev->irq);
 		
 	tms_pci_read_eeprom(dev);
 
-	printk("%s:    Ring Station Address: %pM\n",
-	       dev->name, dev->dev_addr);
+	dev_info(&pdev->dev, "    Ring Station Address: %pM\n", dev->dev_addr);
 		
 	ret = tmsdev_init(dev, &pdev->dev);
 	if (ret) {
-		printk("%s: unable to get memory for dev->priv.\n", dev->name);
+		dev_info(&pdev->dev, "unable to get memory for dev->priv.\n");
 		goto err_out_region;
 	}
 
-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tmspci: fix tr%d in printk
  2010-09-21  7:19 [PATCH] tmspci: fix tr%d in printk Meelis Roos
@ 2010-09-22  1:06 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-22  1:06 UTC (permalink / raw)
  To: mroos; +Cc: netdev

From: Meelis Roos <mroos@linux.ee>
Date: Tue, 21 Sep 2010 10:19:03 +0300 (EEST)

> tmspci driver uses dev->name before register_netdev() and so prints tr%d 
> in initialization messages. Fix it by using dev_info.
> 
> Found and tested on real hardware.
> 
> Signed-off-by: Meelis Roos <mroos@linux.ee>

Applied to net-next-2.6, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-22  1:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-21  7:19 [PATCH] tmspci: fix tr%d in printk Meelis Roos
2010-09-22  1:06 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).