From: Nick Bowler <nbowler@elliptictech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Regression, bisected: reference leak with IPSec since ~2.6.31
Date: Tue, 21 Sep 2010 10:05:01 -0400 [thread overview]
Message-ID: <20100921140501.GA21572@elliptictech.com> (raw)
In-Reply-To: <1285018272.2323.243.camel@edumazet-laptop>
On 2010-09-20 23:31 +0200, Eric Dumazet wrote:
> Could you try following patch ?
>
> [PATCH] ip : fix truesize mismatch in ip fragmentation
[...]
> @@ -658,13 +657,15 @@ static int ip6_fragment(struct sk_buff *skb, int (*output)(struct sk_buff *))
> goto slow_path;
>
> BUG_ON(frag->sk);
> - if (skb->sk) {
> + }
> + if (skb->sk) {
> + skb_walk_frags(skb, frag) {
> frag->sk = skb->sk;
> frag->destructor = sock_wfree;
> - truesizes += frag->truesize;
> + skb->truesize -= frag->truesize;
> }
> }
> -
> +
This hunk introduces some whitespace damage.
Anyway, I tried this with ESP on both IPv4 and IPv6 and it appears to
correct the issue. Thanks!
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2010-09-21 14:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 17:44 Regression, bisected: reference leak with IPSec since ~2.6.31 Nick Bowler
2010-09-20 18:20 ` Eric Dumazet
2010-09-20 19:52 ` Nick Bowler
2010-09-20 20:00 ` David Miller
2010-09-20 21:23 ` Nick Bowler
2010-09-20 20:17 ` Eric Dumazet
2010-09-20 21:31 ` Eric Dumazet
2010-09-21 6:16 ` [PATCH] ip : take care of last fragment in ip_append_data Eric Dumazet
2010-09-21 23:38 ` David Miller
2010-09-22 4:44 ` Eric Dumazet
2010-09-22 4:53 ` David Miller
2010-09-24 21:42 ` David Miller
2010-09-21 9:12 ` Regression, bisected: reference leak with IPSec since ~2.6.31 Jarek Poplawski
2010-09-21 9:21 ` Eric Dumazet
2010-09-21 9:38 ` Jarek Poplawski
2010-09-21 9:55 ` Eric Dumazet
2010-09-21 10:07 ` Eric Dumazet
2010-09-21 10:48 ` Jarek Poplawski
2010-09-21 11:58 ` Eric Dumazet
2010-09-21 12:39 ` Jarek Poplawski
2010-09-21 14:05 ` Nick Bowler [this message]
2010-09-21 14:16 ` [PATCH] ip : fix truesize mismatch in ip fragmentation Eric Dumazet
2010-09-21 15:58 ` [PATCH v3] ip: " Eric Dumazet
2010-09-21 16:26 ` Henrique de Moraes Holschuh
2010-09-21 16:31 ` Eric Dumazet
2010-09-21 18:09 ` Henrique de Moraes Holschuh
2010-09-21 19:24 ` David Miller
2010-09-21 23:06 ` Henrique de Moraes Holschuh
2010-09-21 17:50 ` Jarek Poplawski
2010-09-21 18:47 ` Eric Dumazet
2010-09-21 19:21 ` Jarek Poplawski
2010-09-21 22:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921140501.GA21572@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).