From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
bruce.w.allan@intel.com
Subject: Re: [net-2.6 PATCH 6/6] e1000e: 82579 do not gate auto config of PHY by hardware during nominal use
Date: Wed, 22 Sep 2010 21:11:15 -0700 (PDT) [thread overview]
Message-ID: <20100922.211115.52176292.davem@davemloft.net> (raw)
In-Reply-To: <20100923031700.10976.38.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 22 Sep 2010 20:17:01 -0700
> From: Bruce Allan <bruce.w.allan@intel.com>
>
> For non-managed versions of 82579, set the bit that prevents the hardware
> from automatically configuring the PHY after resets only when the driver
> performs a reset, clear the bit after resets. This is so the hardware can
> configure the PHY automatically when the part is reset in a manner that is
> not controlled by the driver (e.g. in a virtual environment via PCI FLR)
> otherwise the PHY will be mis-configured causing issues such as failing to
> link at 1000Mbps.
> For managed versions of 82579, keep the previous behavior since the
> manageability firmware will handle the PHY configuration.
>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2010-09-23 4:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 3:15 [net-2.6 PATCH 1/6] e1000e: 82577/8/9 issues with device in Sx Jeff Kirsher
2010-09-23 3:15 ` [net-2.6 PATCH 2/6] e1000e: 82579 SMBus address and LEDs incorrect after device reset Jeff Kirsher
2010-09-23 4:10 ` David Miller
2010-09-23 3:15 ` [net-2.6 PATCH 3/6] e1000e: 82566DC fails to get link Jeff Kirsher
2010-09-23 4:10 ` David Miller
2010-09-23 3:16 ` [net-2.6 PATCH 4/6] e1000e: 82579 unaccounted missed packets Jeff Kirsher
2010-09-23 4:11 ` David Miller
2010-09-23 3:16 ` [net-2.6 PATCH 5/6] e1000e: 82579 jumbo frame workaround causing CRC errors Jeff Kirsher
2010-09-23 4:11 ` David Miller
2010-09-23 3:17 ` [net-2.6 PATCH 6/6] e1000e: 82579 do not gate auto config of PHY by hardware during nominal use Jeff Kirsher
2010-09-23 4:11 ` David Miller [this message]
2010-09-23 4:10 ` [net-2.6 PATCH 1/6] e1000e: 82577/8/9 issues with device in Sx David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922.211115.52176292.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=bruce.w.allan@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).