From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, bphilips@novell.com, yi.zou@intel.com
Subject: Re: [net-next-2.6 PATCH] e1000/e1000e/igb/ixgb/ixgbe: set NETIF_F_HIGHDMA for VLAN feature flags
Date: Wed, 22 Sep 2010 23:00:14 -0700 (PDT) [thread overview]
Message-ID: <20100922.230014.57465311.davem@davemloft.net> (raw)
In-Reply-To: <1285219690.2380.70.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 23 Sep 2010 07:28:10 +0200
> Le mercredi 22 septembre 2010 à 21:20 -0700, David Miller a écrit :
>> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> Date: Wed, 22 Sep 2010 20:57:58 -0700
>>
>> > From: Yi Zou <yi.zou@intel.com>
>> >
>> > If the netdev->features is set with NETIF_F_HIGHDMA, we should set the
>> > corresponding netdev->vlan_features as well to allow VLAN netdev created
>> > on top of the real netdev to be able to also benefit from HIGHDMA on 32bit
>> > system, reducing the performance hit that is caused by __skb_linearize(),
>> > particularly for large send. This is fixed in this patch for all Intel e1000,
>> > e1000e, igb, ixgbe, and ixgbe drivers since this should be beneficial
>> > to all devices supported by these drivers.
>> >
>> > Signed-off-by: Yi Zou <yi.zou@intel.com>
>> > Tested-by: Emil Tantilov <emil.s.tantilov@intel.com>
>> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>>
>> Applied.
>
> Maybe this could be done in core network.
Indeeed, just as we do for NETIF_F_GRO now.
next prev parent reply other threads:[~2010-09-23 5:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 3:57 [net-next-2.6 PATCH] e1000/e1000e/igb/ixgb/ixgbe: set NETIF_F_HIGHDMA for VLAN feature flags Jeff Kirsher
2010-09-23 4:20 ` David Miller
2010-09-23 5:28 ` Eric Dumazet
2010-09-23 6:00 ` David Miller [this message]
2010-09-23 6:06 ` Jeff Kirsher
2010-09-23 6:13 ` Eric Dumazet
2010-09-23 6:17 ` Jeff Kirsher
2010-09-23 10:46 ` [PATCH net-next-2.6] net: propagate NETIF_F_HIGHDMA to vlans Eric Dumazet
2010-09-23 16:30 ` Zou, Yi
2010-09-27 1:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922.230014.57465311.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=eric.dumazet@gmail.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).