From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: Mikko Vinni <mmvinni@yahoo.com>
Cc: Karl Hiramoto <karl@hiramoto.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: scheduling while atomic: br2684ctl (atm)
Date: Wed, 22 Sep 2010 14:43:29 -0400 [thread overview]
Message-ID: <20100922144329.0cb3cf86@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <647401.39574.qm@web58406.mail.re3.yahoo.com>
On Wed, 22 Sep 2010 00:42:29 -0700 (PDT)
Mikko Vinni <mmvinni@yahoo.com> wrote:
> I get the following message apparently every time (on 2.6.36-rc4+ at
> least) when killing any old br2684ctl processes.
> "unregister_atmdevice_notifier" was added by
> 7313bb8f ("atm: propagate signal changes via notifier") so perhaps
> the unregister
> part was not tested properly for rcu interaction?
it looks like atomic_notifier_chain_unregister() cannot be called in an
atomic context. the only reason there is a lock is to the list of
br2684_devs atomically. however, i think the event handler could be
made to just register/unregister on module load/unload instead.
> So far I haven't noticed any ill effects from the message. Let me
> know if I should test something. Thanks.
it isnt good. it should be fixed. unless someone has a better idea i
will go ahead with the above.
next prev parent reply other threads:[~2010-09-22 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 7:42 scheduling while atomic: br2684ctl (atm) Mikko Vinni
2010-09-22 18:43 ` chas williams - CONTRACTOR [this message]
2010-09-23 11:50 ` [PATCH] br2684: fix scheduling while atomic Karl Hiramoto
2010-09-23 16:51 ` Mikko Vinni
2010-09-27 1:29 ` David Miller
2010-09-22 21:54 ` scheduling while atomic: br2684ctl (atm) Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922144329.0cb3cf86@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=karl@hiramoto.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmvinni@yahoo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).