netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Tettamanti <kronos.it@gmail.com>
To: netdev@vger.kernel.org
Cc: atl1-devel@lists.sourceforge.net, jcliburn@gmail.com,
	chris.snook@gmail.com, jie.yang@atheros.com
Subject: [PATCH 2/2] atl1: zero out CMB and SBM in atl1_free_ring_resources
Date: Wed, 22 Sep 2010 22:42:31 +0200	[thread overview]
Message-ID: <20100922204231.GA1401@nb-core2.darkstar.lan> (raw)
In-Reply-To: <20100922.132341.48506736.davem@davemloft.net>

They are allocated in atl1_setup_ring_resources, zero out the pointers
in atl1_free_ring_resources (like the other resources).

Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
Acked-by: Chris Snook <chris.snook@gmail.com>
---
 drivers/net/atlx/atl1.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index bbd6e30..c73be28 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
@@ -1251,6 +1251,12 @@ static void atl1_free_ring_resources(struct atl1_adapter *adapter)
 
 	rrd_ring->desc = NULL;
 	rrd_ring->dma = 0;
+
+	adapter->cmb.dma = 0;
+	adapter->cmb.cmb = NULL;
+
+	adapter->smb.dma = 0;
+	adapter->smb.smb = NULL;
 }
 
 static void atl1_setup_mac_ctrl(struct atl1_adapter *adapter)
-- 
1.7.1

  parent reply	other threads:[~2010-09-22 20:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-11 13:12 [BUG] atl1 causes lockup/reboot on resume from STR Luca Tettamanti
2010-09-11 20:47 ` Jarek Poplawski
2010-09-14 13:59   ` Luca Tettamanti
2010-09-14 14:22 ` Luca Tettamanti
2010-09-16 19:29   ` Luca Tettamanti
2010-09-16 19:29   ` [PATCH 1/2] atl1: fix resume Luca Tettamanti
2010-09-16 20:13     ` Chris Snook
2010-09-16 21:13     ` [stable] " Greg KH
2010-09-17  4:47       ` David Miller
2010-09-16 19:29   ` [PATCH 2/2] atl1: zero out CMB and SBM in atl1_free_ring_resources Luca Tettamanti
2010-09-16 20:15     ` Chris Snook
     [not found]   ` <1284717403-12913-1-git-send-email-kronos.it@gmail.com>
2010-09-22 19:34     ` [PATCH 1/2] atl1: fix resume Luca Tettamanti
2010-09-22 20:23       ` David Miller
2010-09-22 20:41         ` Luca Tettamanti
2010-09-22 20:53           ` David Miller
2010-09-22 20:42         ` Luca Tettamanti [this message]
2010-09-22 20:53           ` [PATCH 2/2] atl1: zero out CMB and SBM in atl1_free_ring_resources David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922204231.GA1401@nb-core2.darkstar.lan \
    --to=kronos.it@gmail.com \
    --cc=atl1-devel@lists.sourceforge.net \
    --cc=chris.snook@gmail.com \
    --cc=jcliburn@gmail.com \
    --cc=jie.yang@atheros.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).